This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Change library loading and fix esimd selector function #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbushi25
changed the title
romanovvlad
reviewed
Oct 10, 2022
kbobrovs
reviewed
Oct 11, 2022
kbobrovs
reviewed
Oct 11, 2022
kbobrovs
reviewed
Oct 11, 2022
kbobrovs
reviewed
Oct 11, 2022
kbobrovs
approved these changes
Oct 12, 2022
|
All checks have passed and it has been approved. Can we get this merged soon please? |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…1312) The esimd_test_utils.hpp file has been changed to provide a correct esimd_emulator selector and the library_loading.cpp has been changed to only check for esimd_emulator loading if the filter is set to esimd_emulator. This checks the functionality introduced in the following PR: intel/llvm#6870
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…llvm-test-suite#1312) The esimd_test_utils.hpp file has been changed to provide a correct esimd_emulator selector and the library_loading.cpp has been changed to only check for esimd_emulator loading if the filter is set to esimd_emulator. This checks the functionality introduced in the following PR: intel#6870
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The esimd_test_utils.hpp file has been changed to provide a correct esimd_emulator selector and the library_loading.cpp has been changed to only check for esimd_emulator loading if the filter is set to esimd_emulator. This checks the functionality introduced in the following PR: intel/llvm#6870.
Thanks to @steffenlarsen for his help!