This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Change device preference to acknowledge ESIMD_EMULATOR #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbushi25
changed the title
kbobrovs
suggested changes
Sep 28, 2022
Co-authored-by: kbobrovs <Konstantin.S.Bobrovsky@intel.com>
…t-suite into esimd_emulator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change affects file device_num.cpp in SYCL/Regression. The test has been modified to reflect the presence of ESIMD_EMULATOR when calculating device preferences for the selectors. In particular, it has been changed to prefer the ESIMD device if and only if there are no other suitable devices because running SYCL kernels on ESIMD devices will crash the program. Also, the esimd emulator class in file SYCL/ESIMD/esimd_test_utils.hpp has been changed to actually prefer the ESIMD device. Previously it was just selecting a normal gpu device.