This repository was archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 130
[ESIMD] Add tests for ESIMDOptimizeVecArgCallConv pass. #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
/verify with intel/llvm#6889 |
v-klochkov
reviewed
Sep 27, 2022
// others. | ||
// REQUIRES: gpu | ||
// UNSUPPORTED: cuda || hip | ||
// RUN: %clangxx -fsycl -Xclang -opaque-pointers -fsycl-device-only -Xclang -emit-llvm -o %t.comp.ll %s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You used '-opaque-pointers' here and '-opaque-ptr' for the 1st test above. Do both of spellings supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! No, just one, fixed.
v-klochkov
reviewed
Sep 27, 2022
SYCL/ESIMD/vec_arg_call_conv_ext.cpp
Outdated
// Dummy main to satisfy linker. | ||
int main() { | ||
return 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: please add new line
kbobrovs
added a commit
to intel/llvm
that referenced
this pull request
Sep 27, 2022
…Conv.cpp (#6889) Functions were erased from Module too early, while iterating over them. Also fix signed/unsigned comparison warnings. Tests: intel/llvm-test-suite#1289 This patch also fixes Linux failures. Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
kbobrovs
commented
Sep 27, 2022
/verify with intel/llvm#6889 |
v-klochkov
approved these changes
Sep 27, 2022
kbobrovs
commented
Sep 27, 2022
kbobrovs
commented
Sep 27, 2022
/verify with intel/llvm#6889 |
verification with intel/llvm#6889 passed, #6889 is merged, merging. |
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 16, 2022
Tests were added to intel/llvm-test-suite repo (intel/llvm-test-suite#1289), but they are too low-level to be located in there. Moved them in-tree.
AlexeySachkov
added a commit
to intel/llvm
that referenced
this pull request
Nov 17, 2022
Tests were added to intel/llvm-test-suite repo (intel/llvm-test-suite#1289), but they are too low-level to be located in there. Moved them in-tree.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
* [ESIMD] Add tests for ESIMDOptimizeVecArgCallConv pass. Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…est-suite#1289) * [ESIMD] Add tests for ESIMDOptimizeVecArgCallConv pass. Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Konstantin S Bobrovsky konstantin.s.bobrovsky@intel.com