This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Remove host run and dependencies from SYCL/ESIMD tests #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/ESIMD. Co-authored-by: Sachkov, Alexey <alexey.sachkov@intel.com> Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
v-klochkov
reviewed
Sep 2, 2022
| @@ -33,8 +33,7 @@ int main(int, char **) { | |||
| sycl::device device = queue.get_device(); | |||
| // verify aspect::fp16 due to using sycl::half data type | |||
| // verify aspect::fp64 due to using double data type | |||
| if (!device.is_host() && !device.has(sycl::aspect::fp16) && | |||
| !device.has(sycl::aspect::fp64)) { | |||
| if (!device.has(sycl::aspect::fp16) && !device.has(sycl::aspect::fp64)) { | |||
There was a problem hiding this comment.
The fix is correct.
But the underlying code (that is being fixed here) is totally incorrect IMO.
- The test ctor_vector_core.cpp tests "core" types, i.e. all types except specific. "core" does not include double/half.
So, this check must be not in this file, but in ctor_vector_fp_extra.cpp. - The check must be 'if (!has_fp16 || !has_fp64)' instead of '(!has_fp16 && !has_fp64).
There are several other tests like that.
This can be fixed in a separate PR (I can do that).
v-klochkov
approved these changes
Sep 2, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…1206) This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/ESIMD. Co-authored-by: Sachkov, Alexey <alexey.sachkov@intel.com> Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…1206) This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/ESIMD. Co-authored-by: Sachkov, Alexey <alexey.sachkov@intel.com> Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…llvm-test-suite#1206) This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/ESIMD. Co-authored-by: Sachkov, Alexey <alexey.sachkov@intel.com> Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/ESIMD.