[SYCL][HIP] Improve test for barrier and enable it for HIP #1122
Conversation
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
Fixes a bug in barrier implementation in CUDA and HIP plugins that often caused barrier not to work. The new implementation is also faster. Tests in: intel/llvm-test-suite#1122
|
@steffenlarsen now that intel/llvm#6490 is merged, could we also merge this? I see that the previous jobs failed, should we run these again? |
|
I just reran the tests, but it looks like it times out on L0. On Windows it is having problems with CI. @t4c1 - Could you please have a look? |
|
@steffenlarsen I am not able to access the failure logs. Would it be possible to re-run the CI please. |
|
CI seems to be having some problems with this PR. @t4c1 - Could you please push a merge commit? 🤞 that will help. |
@steffenlarsen currently I am looking into this one. But the CI logs are not available to investigate. |
I can get you more output, but I am hoping if you can push a merge commit to this it will fix the issue we see in Windows CI and hopefully give more information. |
|
Failure in KernelAndProgram/kernel-bundle-merge-options-env.cpp on Windows is a known issue. |
Improves the test for barrier to make it actually fail if the barrier implementation does not work. Tests intel/llvm#6490
…m-test-suite#1122) Improves the test for barrier to make it actually fail if the barrier implementation does not work. Tests intel#6490
Improves the test for barrier to make it actually fail if the barrier implementation does not work.
Tests intel/llvm#6490