This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix resource management in SYCL/Plugin/interop-level-zero.cpp #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL/Plugin/interop-level-zero.cpp
Outdated
| @@ -53,6 +53,10 @@ int main() { | |||
|
|
|||
| backend_input_t<backend::ext_oneapi_level_zero, event> EventInteropInput = { | |||
| ZeEvent}; | |||
| // ZeEvent isn't owning the resource, we cannot transfer ownership that we | |||
There was a problem hiding this comment.
So, the real L0 event resources was created by SYCL RT in https://github.com/intel/llvm-test-suite/pull/1032/files#diff-7d9caf352e8bfa25a4a5e0c96638dce519cf6058ecd8c6d5c1d218de88bd9e6bR20, and will be destroyed at Event dtor, right? Please add this into comment, if yes.
smaslov-intel
approved these changes
May 23, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.