Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only validate URL if provided in proto file for System Software Update #648

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Only validate URL if provided in proto file for System Software Update #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions inbm/cloudadapter-agent/cloudadapter/pb/common/v1/common_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion inbm/proto/common/v1/common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ message UpdateSystemSoftwareOperation {
string url = 1 [(buf.validate.field).cel = {
id: "valid_uri"
message: "url must be a valid URL."
expression: "this.isUri()"
expression: "this == '' || this.isUri()"
},
(buf.validate.field).required = false]; // URL from which to remotely retrieve the package
google.protobuf.Timestamp release_date = 2 [(buf.validate.field).required = false]; // Release date of the new SW update.
Expand Down
Loading
Loading