Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

[CPP Graph] Baichuan & Baichuan2 Enabling #376

Merged
merged 21 commits into from
Oct 13, 2023
Merged

[CPP Graph] Baichuan & Baichuan2 Enabling #376

merged 21 commits into from
Oct 13, 2023

Conversation

Zhenzhong1
Copy link
Contributor

@Zhenzhong1 Zhenzhong1 commented Sep 22, 2023

Type of Change

Feature add and Issues Fix

Description

baichuan

Add extension-test

Expected Behavior & Potential Risk

N/A.

How has this PR been tested?

Manual and CI tests.

Dependency Change?

N/A.

@Zhenzhong1 Zhenzhong1 requested a review from airMeng as a code owner September 22, 2023 09:30
@airMeng
Copy link
Contributor

airMeng commented Sep 22, 2023

please update KERNEL_DEBUG settings as zhenwei issued during the meeting, and prepare readme

Copy link
Contributor

@airMeng airMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except some comments

@airMeng
Copy link
Contributor

airMeng commented Oct 12, 2023

please update KERNEL_DEBUG settings as zhenwei issued during the meeting, and prepare readme

better to finish this in this PR

@Zhenzhong1
Copy link
Contributor Author

please update KERNEL_DEBUG settings as zhenwei issued during the meeting, and prepare readme

better to finish this in this PR

I've removed this feature in this PR, because printing data info using a unified API is not something that can be solved with a few simple lines of code, which means it requires more efforts.

@Zhenzhong1 Zhenzhong1 changed the title [CPP Graph] Baichuan Enabling [CPP Graph] Baichuan & Baichuan2 Enabling Oct 12, 2023
@a32543254
Copy link
Contributor

a32543254 commented Oct 13, 2023

Do we enable FFN fusion / MHA fusion in this pr?

@Zhenzhong1
Copy link
Contributor Author

Do we enable FFN fusion / MHA fusion in this pr?

No. The MHA & FFN fusion to the chatglm & baichuan will be applied in the next PR. I plan to add models first this week.

Copy link
Contributor

@a32543254 a32543254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hshen14 hshen14 merged commit 98e5f9a into main Oct 13, 2023
@hshen14 hshen14 deleted the zhenzhong/baichuan branch October 13, 2023 07:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants