Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

fix normalizer: year, punctuation after number, end token #310

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

Spycsh
Copy link
Contributor

@Spycsh Spycsh commented Sep 14, 2023

Type of Change

bug fix

Description

Fix following problems:

  • number with "," is not treated as digits.
  • Year is not normalized correctly.
  • early-top token not effective.

Expected Behavior & Potential Risk

enhance normalizer

How has this PR been tested?

Run UT

Dependency Change?

None

@Spycsh
Copy link
Contributor Author

Spycsh commented Sep 14, 2023

Hello @VincyZhang , could you please check this CI error, which shows xbyak is not installed and seems irrelevant to this pr?

image

BTW, "Genreate-Report" is misspelled

@VincyZhang
Copy link
Contributor

Hello @VincyZhang , could you please check this CI error, which shows xbyak is not installed and seems irrelevant to this pr?

image BTW, "Genreate-Report" is misspelled

Thanks for reminding, typo fixed in another PR.
For generate report failure, seems due to checkout action. We will take a workaround later. Before that, you can just re-run failed jobs.

@hshen14 hshen14 merged commit 775a125 into main Sep 14, 2023
@hshen14 hshen14 deleted the spycsh/0914demo branch September 14, 2023 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants