This repository was archived by the owner on Jan 28, 2023. It is now read-only.
Improve HAXM installer #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the processing flow according to the return value of check tool: prohibits user to install HAXM only when the system hardware or OS does not support; allows user to retry when VMs are occupying HAXM; and if the system needs to be configured, prompts a warning but proceed installation. When uninstalling, only the occupancy of VMs is checked. * Add status flags according to the error code of check tool * Update the function of checking environment to comply with check tool upgrade * Add message boxes to show and handle the check result for both installation and uninstallation process Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
Provide the detailed report of the installation result in the Finish Page. Reports are divided into 4 types: successful installation, system unsupported, system configuration requirements and the corresponding reference link, and VM occupancy. * Add text definitions used in Finish Page * Load report pages dynamically according to the checking result Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
Update the newest Intel logo in the cover bitmap, which will be shown in the Setup Wizard dialogs. Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
hyuan3
approved these changes
Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve user experience of HAXM installer