Enable dynamic linking MLIR and LLVM #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
May 11, 2024 16:38
…ijie/add-cpu-runner
|
depends on #65 |
ciyongch
reviewed
May 14, 2024
CMakeLists.txt
Outdated
| @@ -10,6 +10,7 @@ list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake") | |||
|
|
|||
| option(GC_LEGACY_ENABLE ON) | |||
| option(GC_TEST_ENABLE "Build the tests" ON) | |||
| option(GC_DEV_LINK_DYN_LLVM "Link dynamic libraries of LLVM and MLIR. For developers only. Do not use it in packing the library." OFF) | |||
There was a problem hiding this comment.
Suggest to change the option name to GC_DEV_LINK_LLVM_DYLIB which is more align with LLVM's LLVM_LINK_LLVM_DYLIB?
There was a problem hiding this comment.
I agree with you. I will change that.
added 2 commits
May 14, 2024 10:23
kurapov-peter
approved these changes
May 14, 2024
lib/gc/CMakeLists.txt
Outdated
| @@ -2,5 +2,7 @@ if(GC_MLIR_CXX_FLAGS) | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${GC_MLIR_CXX_FLAGS}") | |||
| endif() | |||
|
|
|||
| include(../../cmake/functions.cmake) | |||
There was a problem hiding this comment.
This is probably unnecessary, the functions should be available globally.
There was a problem hiding this comment.
After removing it, cmake complains missing command. Let's keep it for now.
ciyongch
approved these changes
May 15, 2024
added 2 commits
May 15, 2024 11:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a cmake option
GC_DEV_LINK_DYN_LLVMfor developer. It reduces binary sizes ofgc-cpu-runnerandgc-optfrom36MBand85MBto0.2MBand2MB. This helps to reduce the link time and the loading time of debuggers likegdb. This option is by default off.