Skip to content

re-struct the directories #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2024
Merged

re-struct the directories #51

merged 2 commits into from
May 10, 2024
+51 −50

Conversation

Menooker
Copy link

@Menooker Menooker commented May 9, 2024 •
edited
Loading

Adjust the source code directory structure, to match the MLIR upstream's. This makes it easier to upstream our code. Created a new top-level directory gc in include/ to match MLIR's include/mlir directory. Moved the dialects to from include/gc-dialects to include/gc/Dialects. Also moved the transforms to include/gc/Transforms. Similar changes are applied on lib/ directory.

New directory tree looks like

include
           gc
               Dialects
                           LinalgX
                           OneDNNGraph
               Transforms
                           Passes.h

@ZhennanQin
Copy link
Contributor

@kurapov-peter This PR will impact all existing and potential PR modifying MLIR components. Please help to review ASAP, thanks a lot.

@Menooker Menooker mentioned this pull request May 9, 2024
Open
Devjiu
Devjiu approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@Devjiu Devjiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this change.
My only concern is that "gc" is commonly used as "garbage collector", but it's not a big issue,

kurapov-peter
kurapov-peter approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@kurapov-peter kurapov-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kurapov-peter kurapov-peter merged commit f563e26 into main May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devjiu Devjiu Devjiu approved these changes

@kurapov-peter kurapov-peter kurapov-peter approved these changes

@ZhennanQin ZhennanQin ZhennanQin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Menooker @ZhennanQin @Devjiu @kurapov-peter