Do not use relative paths in the build script

[AndreyPavlenko]

The script fails when using relative paths and symbolic links.

[leshikus]

I prefer not using variables in scripts when they are not supposed to be changed. Yet this is a minor issue.

[leshikus]

what's the point of introducing the variable? this does not affect execution IMHO

[leshikus]

any variable may hold some invalid value at some point while constant is always a constant

[AndreyPavlenko]

what's the point of introducing the variable? this does not affect execution IMHO

To save the directory path before cd

[AndreyPavlenko]

any variable may hold some invalid value at some point while constant is always a constant

Sorry, didn't get the point. Could you please explain?
These local variables are used to temporary save the paths.

[leshikus]

just use the paths; I cannot see how adding variables adds a value to the script; it adds a few lines and a chance to have less transparent problems later

[AndreyPavlenko]

With relative paths the following code fails, because lvm-project is a link in my env.

        cd ../llvm-project
        git apply ../mlir-extensions/build_tools/patches/*

[AndreyPavlenko]

llvm-project and mlir-extensions are physically located in different folders:

ls -la externals/
...
llvm-project -> /home/andrey/work/llvm-project
mlir-extensions

When running git apply ../mlir-extensions/build_tools/patches/* from the llvm-project folder, the relative path is not valid.

[dchigarev]

I wonder why these two relative directory changes work in your env [1] [2], shouldn't we also save external and graph-compiler-root paths in a variable then?

[AndreyPavlenko]

I wonder why these two relative directory changes work in your env [1] [2], shouldn't we also save external and graph-compiler-root paths in a variable then?

Seems cd can properly resolve the relative paths:

~/work/graph-compiler/externals/llvm-project$ pwd  
/home/andrey/work/graph-compiler/externals/llvm-project
~/work/graph-compiler/externals/llvm-project$ pwd -P
/home/andrey/work/llvm-project
~/work/graph-compiler/externals/llvm-project$ cd ../mlir-extensions/build_tools/patches/
~/work/graph-compiler/externals/mlir-extensions/build_tools/patches$ pwd -P
/home/andrey/work/graph-compiler/externals/mlir-extensions/build_tools/patches

But git and even ls fail to resolve:

~/work/graph-compiler/externals/llvm-project$ git apply ../mlir-extensions/build_tools/patches/*
error: can't open patch '../mlir-extensions/build_tools/patches/*': No such file or directory
~/work/graph-compiler/externals/llvm-project$ ls ../mlir-extensions/build_tools/patches/
ls: cannot access '../mlir-extensions/build_tools/patches/': No such file or directory

[AndreyPavlenko]

Replaced the other relative paths.