Skip to content

Fix the auto cast of brgemm and the correctness issue of deepTileatmul #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2024
Merged

Fix the auto cast of brgemm and the correctness issue of deepTileatmul #247

merged 2 commits into from
Aug 15, 2024

Conversation

zhczhong
Copy link
Member

  1. Fix CPU pipeline failed for some mlir #246. The definition of brgemm autocast is wrong and the root fix is in the upstraem([mlir][linalg] fix linalg.batch_reduce_matmul auto cast llvm/llvm-project#102585)
  2. Matmul correctness check failed #235: The batch_matmul hasn't been supported now and skip it.

@zhczhong zhczhong linked an issue Aug 15, 2024 that may be closed by this pull request
Matmul correctness check failed #235
Closed
@zhczhong zhczhong merged commit eeafe1a into main Aug 15, 2024
4 checks passed
@zhczhong zhczhong mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xurui1995 xurui1995 xurui1995 approved these changes

@ZhennanQin ZhennanQin ZhennanQin approved these changes

@ciyongch ciyongch Awaiting requested review from ciyongch

@WangJialei-A WangJialei-A Awaiting requested review from WangJialei-A

Assignees
No one assigned
Labels
ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPU pipeline failed for some mlir Matmul correctness check failed
3 participants
@zhczhong @xurui1995 @ZhennanQin