Skip to content

FEAT-#145: oneDNN: Support for existing onednn_graph dialect ops. #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2024
Merged

FEAT-#145: oneDNN: Support for existing onednn_graph dialect ops. #133

merged 2 commits into from
Jul 15, 2024

Conversation

AndreyPavlenko
Copy link
Contributor

@AndreyPavlenko AndreyPavlenko commented Jun 26, 2024 •
edited
Loading

Depends on #128

@AndreyPavlenko AndreyPavlenko marked this pull request as ready for review June 26, 2024 23:17
@AndreyPavlenko AndreyPavlenko force-pushed the dnnl-ops branch 3 times, most recently from 3dd24b6 to 8989b37 Compare July 1, 2024 15:23
@AndreyPavlenko AndreyPavlenko changed the title oneDNN: Support for existing onednn_graph dialect ops + unit tests. FEAT-#145: oneDNN: Support for existing onednn_graph dialect ops. Jul 2, 2024
@AndreyPavlenko AndreyPavlenko force-pushed the dnnl-ops branch 4 times, most recently from 2f15cb2 to bd5ff27 Compare July 9, 2024 13:03
dchigarev
dchigarev reviewed Jul 9, 2024
View reviewed changes
@AndreyPavlenko AndreyPavlenko requested a review from dchigarev July 12, 2024 10:50
dchigarev
dchigarev approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is there a plan to test parsing of ops with different attributes? (does onednn dialect support non-default op attributes at all at this point?)

@AndreyPavlenko
Copy link
Contributor Author

LGTM! Is there a plan to test parsing of ops with different attributes? (does onednn dialect support non-default op attributes at all at this point?)

There are some tests in TestJsonParser.

@AndreyPavlenko AndreyPavlenko merged commit 1f1eef9 into intel:main Jul 15, 2024
4 checks passed
dchigarev pushed a commit to dchigarev/graph-compiler that referenced this pull request Jul 29, 2024
@AndreyPavlenko @dchigarev
FEAT-intel#145: oneDNN: Support for existing onednn_graph dialect ops. (
a709315 
intel#133)

* FEAT-intel#145: oneDNN: Support for existing onednn_graph dialect ops.

Closes intel#145.
@intel intel deleted a comment Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurapov-peter kurapov-peter kurapov-peter approved these changes

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreyPavlenko @kurapov-peter @dchigarev