Skip to content

Consolidate tests in a single location #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

kurapov-peter
Copy link
Contributor

Let's keep it clean

@kurapov-peter kurapov-peter requested a review from Menooker June 6, 2024 11:45
@ciyongch
Copy link
Contributor

ciyongch commented Jun 7, 2024

Separating the gtests and lit tests seems more reasonable? And this structure is what upstream MLIR did?

@Menooker
Copy link

Menooker commented Jun 7, 2024

what about a structure like this?

tests
       \
        dnnl
               \
                 dnnl tests
        mlir    <-------- file structure kept same as upstream
              \
                tests
                       \
                         mlir lit tests
                unittest
                        \
                          mlir unittests
                lit.cfg.py
                lit.site.cfg.py.in

And we may move the tests/lit.cfg.py tests/lit.site.cfg.py.in into tests/mlir/tests, and keep the directory unittest out of mlir/tests, to keep it the same structure of MLIR? I suppose there will be some changes needed in tests/lit.cfg.py tests/lit.site.cfg.py.in to update the paths for llvm-lit.

@kurapov-peter kurapov-peter force-pushed the pakurapo/test-cleanup branch from 49e67bf to 467c37c Compare June 7, 2024 13:42
@kurapov-peter
Copy link
Contributor Author

what about a structure like this?

Yeah, sounds good, I've restructured it in a similar way and added a note. Now mlir strictly follows upstream structure.

@Menooker Menooker merged commit f072ff0 into main Jun 11, 2024
4 checks passed
zhczhong pushed a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants