Klocwork check null before dereference in acl_kernel_if #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherry-yuan
force-pushed
the
klocwork_null_deref
branch
from
09daec0 to
c0a4ea6
Compare
pcolberg
suggested changes
Dec 14, 2021
There was a problem hiding this comment.
Thanks @sherry-yuan! I would suggest to simply go with assert().
sherry-yuan
force-pushed
the
klocwork_null_deref
branch
from
7eda565 to
2c61ca9
Compare
Pointer 'kern->accel_csr' returned from call to function 'acl_malloc' at line 875 may be NULL and may be dereferenced at line 886.
Pointer 'kern->accel_perf_mon' returned from call to function 'acl_malloc' at line 877 may be NULL and may be dereferenced at line 898.
Pointer 'kern->accel_num_printfs' returned from call to function 'acl_malloc' at line 879 may be NULL and may be dereferenced at line 908.
Pointer 'kern->accel_job_ids' returned from call to function 'acl_malloc' at line 947 may be NULL and will be dereferenced at line 962.
…encing Pointer 'kern->accel_invoc_queue_depth' returned from call to function 'acl_malloc' at line 949 may be NULL and will be dereferenced at line 961.
Pointer 'kern->accel_queue_front' returned from call to function 'acl_malloc' at line 954 may be NULL and will be dereferenced at line 964
Pointer 'kern->accel_queue_back' returned from call to function 'acl_malloc' at line 955 may be NULL and will be dereferenced at line 965
pcolberg
force-pushed
the
klocwork_null_deref
branch
from
2c61ca9 to
e0a017b
Compare
pcolberg
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following klocwork issues in acl_kernel_if.cpp: