Remove ACL_CONTEXT_MSIM #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcolberg
reviewed
Jan 30, 2023
There was a problem hiding this comment.
Thanks @intel-liudean, this looks good. Could you include a brief statement in the commit message why it is unused and safe to remove? Basically state what msim was, and that it has been replaced with mpsim. @sophimao can assist you with this.
This is set by the flag CL_CONTEXT_MSIM_DEVICE_INTELFPGA, is unused and safe to remove. Detailed reasons: The MSIM flow is the original simulation flow that involves manually launching the simulator, and it is for internal-use-only. The introduction of MPSIM replaces the use of MSIM and is the public flow that users should use as of now. We as internal developers no longer use the MSIM flow, and based off the above two points, it is safe to remove support for the MSIM flow Tests Done: Runtime Unit Tests
intel-liudean
force-pushed
the
simulation-device-selector
branch
from
b81ad1a to
d64e0d0
Compare
|
This is done. |
sophimao
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is set by the flag CL_CONTEXT_MSIM_DEVICE_INTELFPGA, is unused and safe to remove.
Tests Done:
Runtime Unit Tests