Skip to content

l_copy_and_adjust_arguments_for_device: reduce scope of device-side buffer increment #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2022

Conversation

pcolberg
Copy link
Contributor

@pcolberg pcolberg commented May 4, 2022

This ensures the buffer increment is initialized to zero for every
kernel argument, not only the first one. This has no functional impact
since all kernel argument types use a non-default buffer increment.

This is a prerequisite for #103.

…uffer increment

This ensures the buffer increment is initialized to zero for every
kernel argument, not only the first one. This has no functional impact
since all kernel argument types use a non-default buffer increment.

Signed-off-by: Peter Colberg <peter.colberg@intel.com>
@pcolberg pcolberg added the enhancement New feature or request label May 4, 2022
@pcolberg pcolberg added this to the 2022.3 milestone May 4, 2022
@pcolberg pcolberg self-assigned this May 4, 2022
This improves readability and potentially avoids future mistakes.

Signed-off-by: Peter Colberg <peter.colberg@intel.com>
Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Peter!

@pcolberg pcolberg merged commit bd7f107 into intel:main May 5, 2022
@pcolberg pcolberg deleted the buf_incr branch May 5, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants