fix: Improve subversion detection logic #4749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmfrederik
force-pushed
the
fixes/subversion
branch
from
dccfdd4 to
3a84751
Compare
qmfrederik
force-pushed
the
fixes/subversion
branch
from
3a84751 to
036ec69
Compare
terriko
approved these changes
Feb 20, 2025
Collaborator
terriko
left a comment
terriko
left a comment
There was a problem hiding this comment.
I'm actually kind of surprised this one doesn't produce any false positives since it really looks like a generic version, but I guess there's just enough to distinguish it because we're not breaking the existing tests. Let's get it merged, then. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.