fix: update binutils pattern #4077
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix binutils pattern to return 2.32.0 instead of 2.32.0.20190204 from the following string: Linux version 4.14.206-perf (oe-user@oe-host) (clang version 6.0.9 for Android NDK, GNU ld (GNU Binutils) 2.32.0.20190204) #1 PREEMPT Mon Jan 29 09:57:30 UTC 2024 Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4077 +/- ##
==========================================
+ Coverage 75.41% 80.90% +5.48%
==========================================
Files 808 822 +14
Lines 11983 12699 +716
Branches 1598 1978 +380
==========================================
+ Hits 9037 10274 +1237
+ Misses 2593 2010 -583
- Partials 353 415 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
terriko
approved these changes
Apr 24, 2024
Contributor
terriko
left a comment
terriko
left a comment
There was a problem hiding this comment.
Ahh, versions are the worst. I wonder how long before someone files a CVE with the date stamp in and we have to work with those, but I think we should deal with that later if it becomes an issue.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix binutils pattern to return
2.32.0instead of2.32.0.20190204from the following string:Linux version 4.14.206-perf (oe-user@oe-host) (clang version 6.0.9 for Android NDK, GNU ld (GNU Binutils) 2.32.0.20190204) #1 PREEMPT Mon Jan 29 09:57:30 UTC 2024