Skip to content

Conversation

@tahifahimi
Copy link
Contributor

Close #3798

@terriko
Copy link
Contributor

terriko commented Feb 8, 2024

I'm re-running the windows tests because I'm curious what's going on there, but it's highly unlikely to be related to your PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (chore-precommit-config@fe1f82b). Click here to learn what that means.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             chore-precommit-config    #3799   +/-   ##
=========================================================
  Coverage                          ?   80.68%           
=========================================================
  Files                             ?      806           
  Lines                             ?    11967           
  Branches                          ?     1595           
=========================================================
  Hits                              ?     9655           
  Misses                            ?     1893           
  Partials                          ?      419           
Flag Coverage Δ
longtests 80.10% <0.00%> (?)
win-longtests 78.49% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tahifahimi
Copy link
Contributor Author

tahifahimi commented Feb 9, 2024

I checked the pipeline and stack in my own fork, and I think the problem is related to the file async_utils.py line 90 with the asyncio. It seems that It shuts down the socket.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're set to merge. Thank you!

@terriko terriko merged commit a69f535 into intel:chore-precommit-config Feb 12, 2024
terriko added a commit that referenced this pull request Feb 13, 2024
* chore: update pre-commit config

* chore: update inconsistency in files with black v24.1.1 (#3799)

---------

Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: tahera_fahimi <46875632+tahifahimi@users.noreply.github.com>
Co-authored-by: Terri Oda <terri.oda@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants