-
Notifications
You must be signed in to change notification settings - Fork 578
feat: sbom auto detection for command line #3734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3734 +/- ##
==========================================
+ Coverage 75.41% 78.77% +3.36%
==========================================
Files 808 807 -1
Lines 11983 11880 -103
Branches 1598 1374 -224
==========================================
+ Hits 9037 9359 +322
+ Misses 2593 2091 -502
- Partials 353 430 +77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I opened this PR for initial review but test_config_generator of test_cli.py probably will fail as i have made arguement default of --sbom to "".😅 |
|
Hey @anthonyharrison @terriko can you guide me with this one, the feature is working as expected but I am little unsure if its the correct way of approaching it. Thanks😊 |
terriko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you just need to change test_config_generator which can be found in test_cli.py:
Line 752 in 9342261
| def test_config_generator(self, args, expected_files, expected_contents, caplog): |
If you look above that you can see the data structures it's expecting to find. You probably just need to take out the line that includes spdx, although you might need to replace it with a blank. Experiment!
terriko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, but needs at least one test. The comment from CodeCov above will give you a list of specific lines that need testing.
|
closing and reopening for test. |
|
I have also re-enable the test_sbom which was failing due the overwritting of entries by OSV. |
terriko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great now!
fix: #3437
Added Sbom Auto Detection to work out the Sbom type automatically.