chore: update SBOM for Python 3.11 #3446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
chore-sbom-py3.11
branch
from
ed49bc2 to
44d347b
Compare
Contributor
|
Moment of truth for our CI changes. Closing and re-opening for tests. |
Codecov Report
@@ Coverage Diff @@
## main #3446 +/- ##
==========================================
+ Coverage 74.82% 80.34% +5.52%
==========================================
Files 758 758
Lines 11616 11811 +195
Branches 1571 1630 +59
==========================================
+ Hits 8692 9490 +798
+ Misses 2581 1880 -701
- Partials 343 441 +98
Flags with carried forward coverage won't be shown. Click here to find out more. see 26 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
omg, this looks like it's working. I'm going to tweak this a bit to handle the longtests as well (and probably disable a few more things) and maybe pull the ci changes into a separate PR and get a colleague to do code review. |
terriko
added a commit
to terriko/cve-bin-tool
that referenced
this pull request
Oct 25, 2023
The earlier PR skipping tests caused issues with our branch protection rules and had to be disabled because it blocked merging of pull requests (if the tests were skipped, the PR could never be merged). This allows part of the job to run (so it'll pass branch protection checks) while skipping the install and running of tests on sbom jobs provided by our automated job. Note that this is the same code as I had in intel#3446 but I'm separating it out so it gets a proper code review from someone who is not me. Signed-off-by: Terri Oda <terri.oda@intel.com>
github-actions
bot
force-pushed
the
chore-sbom-py3.11
branch
from
cb26062 to
8ffbafb
Compare
terriko
added a commit
that referenced
this pull request
Oct 30, 2023
The earlier PR skipping tests caused issues with our branch protection rules and had to be disabled because it blocked merging of pull requests (if the tests were skipped, the PR could never be merged). This allows part of the job to run (so it'll pass branch protection checks) while skipping the install and running of tests on sbom jobs provided by our automated job. Note that this is the same code as I had in #3446 but I'm separating it out so it gets a proper code review from someone who is not me. Signed-off-by: Terri Oda <terri.oda@intel.com>
terriko
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action