fix lm head bug and rm clear_mem_reach_threhold #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshen14
approved these changes
Nov 5, 2025
for more information, see https://pre-commit.ci
xin3he
approved these changes
Nov 6, 2025
Contributor
xin3he
left a comment
xin3he
left a comment
There was a problem hiding this comment.
LGTM, wondering why using global_batch_size to replace pick_samples
for more information, see https://pre-commit.ci
Contributor
Author
|
hpu ut issue is probably related to envs, merge first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.