-
Notifications
You must be signed in to change notification settings - Fork 60
AutoRoundMLLM supports scheme and fix device_map=dict regression #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: n1ck-guo <heng.guo@intel.com>
for more information, see https://pre-commit.ci
wenhuach21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix device_map=dict
for more information, see https://pre-commit.ci
| import habana_frameworks.torch.core as htcore # pylint: disable=E0401 | ||
| import habana_frameworks.torch.hpu as hthpu # pylint: disable=E0401] | ||
|
|
||
| def _set_device(self, device_map): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add type
| tmp_device = detect_device(val) | ||
| tmp_device = tmp_device.split(":")[0] | ||
| tmp_devices.append(tmp_device) | ||
| tmp_devices = list(set(tmp_devices)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set could not keep the order, which may increase debugging effort in the future.
How about using this one
https://github.com/intel/auto-round/blob/main/auto_round/autoround.py#L789
No description provided.