Call cp(1) relative to PATH
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contrast to other coreutils binaries used throughout the code, cp(1) gets called with an absolute path which assumes the binary resides in `/bin`. This commit removes the absolute path to search for cp(1) relative to the search paths given in the `PATH` environment variable. Using an absolute path to call binaries is incompatible with distributions which do not follow the Filesystem Hierachy Standard; NixOS is an example. Also, as other coreutils binaries merely mention the binary's name, it is more consistent to call cp(1) in the same way. Signed-off-by: Vincent Haupert <mail@vincent-haupert.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to other coreutils binaries used throughout the code,
cp(1) gets called with an absolute path which assumes the binary
resides in
/bin. This commit removes the absolute path to searchfor cp(1) relative to the search paths given in the
PATHenvironment variable.
Using an absolute path to call binaries is incompatible with
distributions which do not follow the Filesystem Hierachy Standard;
NixOS is an example. Also, as other coreutils binaries merely mention
the binary's name, it is more consistent to call cp(1) in the same way.
Signed-off-by: Vincent Haupert mail@vincent-haupert.de