update to CPU fraction auto-tuning algorithm #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check to exclude operations with failed DSA calls from considering by the CPU fraction auto-tuning algorithm Added documentation on common usage modes for DTO. Signed-off-by: Sydir, Jerry <jerry.sydir@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refines the CPU fraction auto-tuning algorithm by filtering out failed DSA operations from its metrics, bumps the default minimum buffer size to 64 KB, and expands the README with common DTO usage scenarios.
- Exclude failed DSA completions from auto-tuning calculations.
- Change
DTO_DEFAULT_MIN_SIZEfrom 16 384 to 65 536. - Add documented examples of latency, power, cycle, and cache-pollution usage modes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dto.c | Early-return on non-successful DSA completions in dsa_wait_and_adjust and update min size. |
| README.md | New section detailing common DTO usage modes and their recommended environment variable settings. |
Comments suppressed due to low confidence (1)
dto.c:435
- Consider adding a unit or integration test to verify that failed DSA completions are properly excluded from the auto-tuning metrics.
if(*comp != DSA_COMP_SUCCESS) {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
byrnedj
reviewed
Jun 12, 2025
| // operations that have failed (mostly due to page fault) return very quickly and cause the algorithm | ||
| // to think that the DSA operation was faster than it really was. We exclude them from the calculation. | ||
| if(*comp != DSA_COMP_SUCCESS) { | ||
| return; |
byrnedj
reviewed
Jun 12, 2025
| @@ -44,7 +44,7 @@ | |||
| */ | |||
| #define MAX_WQS 32 | |||
| #define MAX_NUMA_NODES 32 | |||
| #define DTO_DEFAULT_MIN_SIZE 16384 | |||
| #define DTO_DEFAULT_MIN_SIZE 65536 | |||
There was a problem hiding this comment.
I set it to 32K should we pick 48K as the middle? if not, I am fine with 64K
There was a problem hiding this comment.
Lets set it to 64K. There are cases where even 64K is marginal.
Signed-off-by: Sydir, Jerry <jerry.sydir@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check to exclude operations with failed DSA calls from considering by the CPU fraction auto-tuning algorithm
Added documentation on common usage modes for DTO.
Modified Default Min size to 64K