Tf2estimator on Pyspark support tensorboard #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangw1234
reviewed
Feb 8, 2022
| if not fs.exists(remote_dir): | ||
| fs.mkdir(remote_dir) | ||
| cmd = 'hdfs dfs -put -f {}/* {}/'.format(local_dir, remote_dir) | ||
| process = subprocess.Popen(cmd, shell=True) |
There was a problem hiding this comment.
Is it possible to just use pyarrow or hadoop command instead of interleaving them together?
There was a problem hiding this comment.
using pyarrow to copy hdfs tree is a little complex. will change to use command all the ways.
yangw1234
reviewed
Feb 8, 2022
| put_local_dir_to_remote(os.path.dirname(replaced_checkpoint_path), | ||
| original_checkpoint_dir) | ||
| finally: | ||
| shutil.rmtree(os.path.dirname(replaced_checkpoint_path)) |
There was a problem hiding this comment.
If put_local_dir_to_remote failed, maybe we should not delete replaced_checkpoint_path otherwise user's training result will be lost.
How about printing a warning stating that there is an error and the checkpoint is located at xxx and then users will have a chance to get them manually.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tf2estimator on Pyspark support tensorboard for fit and evaluate.