Fix the issue that NPE thrown by ClusterServing.jedisPool with Kafka #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed was configured as kafka
Litchilitchy
changed the title
Litchilitchy
approved these changes
Nov 16, 2021
dding3
pushed a commit
to dding3/BigDL
that referenced
this pull request
Nov 17, 2021
* init commit * refactor * add unit test * add pytorch tests * add tf ray unit tests * fix style * fix tests * add tests back * fix tests * fix tests * fix tesets * fix tests * fix style * fix style * fix tests
dding3
pushed a commit
to dding3/BigDL
that referenced
this pull request
Nov 17, 2021
* init commit * refactor * add unit test * add pytorch tests * add tf ray unit tests * fix style * fix tests * add tests back * fix tests * fix tests * fix tesets * fix tests * fix style * fix style * fix tests
dding3
pushed a commit
to dding3/BigDL
that referenced
this pull request
Nov 17, 2021
* init commit * refactor * add unit test * add pytorch tests * add tf ray unit tests * fix style * fix tests * add tests back * fix tests * fix tests * fix tesets * fix tests * fix style * fix style * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that NPE thrown by ClusterServing.jedisPool when queueUsed was configured as kafka
In PreProcessing.scala if there is an error when invoking decodeArrowBase64, it will unconditionally store the NAN value into Redis. ClusterService.jedisPool would not be initialized if queueUsed was set as kafka in config.yaml. Then it will lead to this issue.