-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
peer discovery by shard status with flexible url prefix #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
added
A0-core
Affects a core part
B1-releasenotes
C1-low 📌
Does not elevate a release containing this beyond "low priority"
E0-breaksnothing
labels
Dec 13, 2023
clangenb
reviewed
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I have one question, regarding the approach in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A0-core
Affects a core part
B1-releasenotes
C1-low 📌
Does not elevate a release containing this beyond "low priority"
E0-breaksnothing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1524
closes #1529
Instead of broadcasting sidechain blocks to all sovereign enclaves of any MRENCLAVE, this PR changes the behavior to restrict broadcast only to enclaves who have touched the shard before.
We hereby introduce
ShardConfig
for this, which also allows custom shards to be initiated by any enclave.In the future, this can be extended to have more control over the validateer set for a shard.
I also sneaked in other minor things: