Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer discovery by shard status with flexible url prefix #1532

Merged
merged 17 commits into from
Dec 17, 2023

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Dec 13, 2023

closes #1524
closes #1529

Instead of broadcasting sidechain blocks to all sovereign enclaves of any MRENCLAVE, this PR changes the behavior to restrict broadcast only to enclaves who have touched the shard before.

We hereby introduce ShardConfig for this, which also allows custom shards to be initiated by any enclave.
In the future, this can be extended to have more control over the validateer set for a shard.

I also sneaked in other minor things:

@brenzi brenzi added A0-core Affects a core part B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing labels Dec 13, 2023
@brenzi brenzi marked this pull request as ready for review December 15, 2023 06:07
@brenzi brenzi requested a review from clangenb December 15, 2023 06:07
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I have one question, regarding the approach in general.

enclave-runtime/src/tls_ra/tls_ra_client.rs Outdated Show resolved Hide resolved
service/src/worker.rs Show resolved Hide resolved
@brenzi brenzi merged commit c5d61cc into master Dec 17, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-core Affects a core part B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[live] sidechain stuck at producing block 1 [live] peer discovery broken
2 participants