-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom dependencies on parentchain runtimes to decode L1 Events #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain. cargo downgrades break build
brenzi
added
A0-core
Affects a core part
A2-applibs
Affects app-libs, i.e. runtime or stf
labels
Dec 19, 2023
brenzi
changed the title
Ab/custom parentchain runtime deps
flexible dependencies on parentchain runtimes to decode L1 Events
Dec 19, 2023
brenzi
commented
Dec 19, 2023
brenzi
commented
Dec 19, 2023
brenzi
changed the title
flexible dependencies on parentchain runtimes to decode L1 Events
custom dependencies on parentchain runtimes to decode L1 Events
Dec 19, 2023
clangenb
reviewed
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, only some minor issues, and I am happy about the size of this PR. ;)
brenzi
commented
Dec 20, 2023
Hmmm, by now I believe we can probably get rid of runtime deps entirely. Would accelerate the build quite a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A0-core
Affects a core part
A2-applibs
Affects app-libs, i.e. runtime or stf
B1-releasenotes
C1-low 📌
Does not elevate a release containing this beyond "low priority"
E0-breaksnothing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1506
ita-parentchain-interface
ita_parentchian_interface
is now the only crate that depends on runtime implementationsdecoding into proper types was too much of a hssle for now. therefore, we just use Default fmt to print events
On Solochains, L1 events now look like this:
On Parachains, L1 events now look like: