-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip indirect invocations for initial sync of integritee parentchain #1517
Conversation
… explicitly request this
hmmm. the OCW M6 test fails during the second run. AliceIncognito Balance is wrong. I think we need to pass the shard birth header along with the provisioning payload for the non-primary worker still strange is this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, it is hard to grasp if we have been thinking about all things here, or if this is very brittle.
I think so, what does worker2 otherwise do? Fast sync until his own birth header? This would be wrong obviously.
It could be that we provision the shielding key too late. If there is no shielding key provisioned, the worker2 might use one that it initialized itself, which results in the error. |
Alternatively, worker2 could sync the chain and scan for register enclave events from the primary worker. Or we introduce the "birth header" storage onchain for each shard. |
I did change the order of things, yes. will keep an eye on this |
hmm, my thinking was wrong. status quo is that the second OCW receives the light client state from the first one and therefore does not sync the blocks between birth header and the last synced block of the peer. (due to my reordering of provisioning?) I decided to provision |
closes #1514, #1519
shard_creation_header
, the integritee parentchain header of the first registered enclave for own shard: