Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support json-rpc request string id #1512

Merged
merged 4 commits into from
Dec 1, 2023
Merged

support json-rpc request string id #1512

merged 4 commits into from
Dec 1, 2023

Conversation

kziemianek
Copy link
Contributor

Node fails silently to send direct rpc request status updates if request's id type is String. Client hangs out waiting for more responses because of do_watch: true.

[2023-09-14T12:18:18Z WARN  itp_top_pool::watcher] failed to update connection state: InvalidConnectionHash
[2023-09-14T12:18:24Z WARN  itp_top_pool::watcher] failed to send status update to rpc client: InvalidConnectionHash, InSidechainBlock(0xe85176151f962568ec126d7c8dd30fcba106d35388093c39d4937b60e29c0a85)

According to JSON-RPC 2.0 spec field id can be of type String, Number, or NULL.

We reported it and fixed in Litentry repo.

@clangenb clangenb added A0-core Affects a core part B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing labels Nov 30, 2023
clangenb
clangenb approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, simple and easy. Thanks for the contribution.

@clangenb clangenb merged commit a36ae4b into integritee-network:master Dec 1, 2023
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
A0-core Affects a core part B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kziemianek @clangenb