Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up cargo dependencies #1503

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Clean up cargo dependencies #1503

merged 5 commits into from
Nov 28, 2023

Conversation

Kailai-Wang
Copy link
Contributor

This PR:

  • removes unneeded cargo dependencies with the help of cargo machete
  • removes some commented deps
  • fixes some clippy errors in enclave-runtime/ (somehow I found this in Litentry repo, but not in integritee-repo, why? We use the same toolchain version)

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce, great cleanup, I only have one comment!

I don't know about the clippy thing, but I have noticed too already that we get erros in the encointer fork, but not here. Should definitely be investigated: #1504

Thanks a lot for the contribution!

Cargo.toml Outdated Show resolved Hide resolved
@clangenb clangenb added B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" A7-somethingelse E0-breaksnothing labels Nov 27, 2023
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me now! I haven't looked at the teeracle integration test yet, but by now I am quite sure it is our api-key. Or maybe an issue with the api-keys if the PR is from a fork.

@clangenb clangenb merged commit 882e394 into integritee-network:master Nov 28, 2023
36 of 37 checks passed
@Kailai-Wang Kailai-Wang deleted the clean-cargo-dep branch November 28, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A7-somethingelse B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants