Publish mrenclave #1473
Merged
Publish mrenclave #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
added
B1-releasenotes
C1-low 📌
clangenb
commented
Oct 23, 2023
clangenb
force-pushed
the
cl/publish-mrenclave
branch
from
600af1d
to
78bfcee
Compare
clangenb
force-pushed
the
cl/publish-mrenclave
branch
from
c2afb65
to
0cfb560
Compare
clangenb
commented
Oct 27, 2023
Comment on lines
+64
to
+65
| SGX_MODE_LOWERCASE=$(echo "${${{ matrix.sgx_mode }},,}") | ||
| echo "IMAGE_SUFFIX=$SGX_MODE_LOWERCASE-${{ matrix.flavor_id }}-${{ github.sha }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
A docker image tag must have lower case letters only.
| - name: Create Enclave Digest File | ||
| run: | | ||
| mrenclave_hex=$(docker run integritee-worker-${{ env.IMAGE_SUFFIX }} mrenclave | grep -o -E '[0-9a-fA-F]{64}') | ||
| echo "$mrenclave_hex" > mrenclave-${{ env.IMAGE_SUFFIX }}.hex |
There was a problem hiding this comment.
I would like to confirm consensus here: We create a mrenclave-${{ env.IMAGE_SUFFIX }}.hex for each flavour we build, which contains the mrenclave, example: mrenclave-hw-sidechain-<github-sha>.hex.
Objections: @brenzi?
|
I merge this for now, so that I can make an upstream merge in OLI's merge. Any amendments can be done later. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mrenclave-${{ env.IMAGE_SUFFIX }}.hexcontaining the mrenclave for each flavor we build, e.g.,mrenclave-hw-sidechain-<github-sha>.hex. Closes Get mrenclave at build time #1472mrenclaveto the docker image we build, which prints the mrenclave:docker run integritee-service mrenclave