Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies to polkadot-v0.9.32 #159

Merged
merged 13 commits into from
Dec 12, 2022

Conversation

BillyWooo
Copy link
Contributor

As title:

  • update to polkadot-v0.9.32
  • mainly change name "Event" -> "RuntimeEvent", etc.
  • add pallet_preimage
  • update list_benchmark! and add_benchmark! to define_benchmarks!

TODO: please update benchmark file accordingly.

Copy link
Collaborator

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks very clean. I only have a few minor remarks.

@@ -113,7 +113,7 @@ pub fn new_partial(
let slot_duration = sc_consensus_aura::slot_duration(&*client)?;

let import_queue =
sc_consensus_aura::import_queue::<AuraPair, _, _, _, _, _, _>(ImportQueueParams {
sc_consensus_aura::import_queue::<AuraPair, _, _, _, _, _>(ImportQueueParams {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always love it, when a parameters disappears. :D

list_benchmark!(list, extra, pallet_utility, Utility);
list_benchmark!(list, extra, pallet_teeracle, Teeracle);
list_benchmark!(list, extra, pallet_sidechain, Sidechain);
list_benchmarks!(list, extra);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the improvement here.

Comment on lines 48 to 59
// // Storage: Multisig Multisigs (r:1 w:1)
// // Storage: Multisig Calls (r:1 w:1)
// // Storage: unknown [0x3a65787472696e7369635f696e646578] (r:1 w:0)
// fn as_multi_create_store(s: u32, z: u32, ) -> Weight {
// Weight::from_ref_time(111_754_000)
// // Standard Error: 282_000
// .saturating_add(Weight::from_ref_time(956_000)).saturating_mul(s.into())
// // Standard Error: 0
// .saturating_add(Weight::from_ref_time(6_000)).saturating_mul(z.into())
// .saturating_add(T::DbWeight::get().reads(3))
// .saturating_add(T::DbWeight::get().writes(2))
// }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the calls don't exist anymore, please just delete them.

}
// // Storage: unknown [0x3a65787472696e7369635f696e646578] (r:1 w:0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, please delete them.

Comment on lines 194 to 205
pub mod currency {
pub type Balance = u128;

pub const UNIT: Balance = 1_000_000_000_000;
pub const DOLLARS: Balance = UNIT; // 1_000_000_000_000
pub const CENTS: Balance = DOLLARS / 100; // 10_000_000_000
pub const MILLICENTS: Balance = CENTS / 1_000; // 10_000_000

/// The existential deposit.
pub const EXISTENTIAL_DEPOSIT: Balance = 10 * CENTS;
}
use crate::currency::DOLLARS;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use TEERs instead of dollars, see:

pub const MICROTEER: Balance = 1_000_000;

So, you can delete this. If DOLLARS is needed below, you can replace the value with TEER

@clangenb
Copy link
Collaborator

The CI seems to want the protobuf compiler now. According to the substrate docs, it can be installed with:

sudo apt install --assume-yes protobuf-compiler

It would be super cool, if you can add this to the CI.

@BillyWooo BillyWooo changed the title Pr polkadot v0.9.32 update dependencies to polkadot-v0.9.32 Dec 11, 2022
@clangenb
Copy link
Collaborator

Hmm, this error is weird, do we need to update srtool maybe?

@BillyWooo
Copy link
Contributor Author

The srtool, from log, is already the latest version. Also not the --root flag problem. Still investigating...

Copy link
Collaborator

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I am amazed by the fix. Good catch!

Comment on lines +226 to +230
pub BlockWeights: frame_system::limits::BlockWeights =
frame_system::limits::BlockWeights::with_sensible_defaults(
(2u64 * WEIGHT_PER_SECOND).set_proof_size(u64::MAX),
NORMAL_DISPATCH_RATIO,
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you find our what you need to do to solve this? I am now having the same issue on the parachain, but my weight declaration is the same as statemines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillyWooo BillyWooo deleted the pr-polkadot-v0.9.32 branch March 16, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants