fix(github_repository): wire code_security in security_and_analysis read/write#3431
Open
nicktrn wants to merge 1 commit into
Open
fix(github_repository): wire code_security in security_and_analysis read/write#3431nicktrn wants to merge 1 commit into
nicktrn wants to merge 1 commit into
Conversation
integrations#2935 added the code_security schema block but did not extend calculateSecurityAndAnalysis (write) or flattenSecurityAndAnalysis (read) to handle it. Effect: code_security declarations are silently dropped on apply, and the field is never populated in state on refresh, producing a permanent `+ code_security` diff on every plan. Mirrors the existing advanced_security handling. secret_scanning_ai_detection and secret_scanning_non_provider_patterns are also affected by integrations#2935 but require go-github type additions, so they are out of scope here.
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2935 added the
code_securityschema block. Neither read nor write paths were extended to handle it.Effect:
code_security { status = ... }in config is silently droppedcode_securitynever populated in state on refresh -> permanent+ code_securitydiff on every planFix mirrors existing
advanced_securityhandling in both functions.TestAccGithubRepositorySecurity(added in #2935) already assertscode_security. Was broken pre-fix. Passes post-fix.Out of scope:
secret_scanning_ai_detection,secret_scanning_non_provider_patterns. Schema exists from #2935 but go-github v86 lacks the types. Separate fix needed - go-github update first.