refactor: migrate resource_github_actions_environment_variable to tflog#3325
refactor: migrate resource_github_actions_environment_variable to tflog#3325texasich wants to merge 3 commits into
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
7a882e5 to
d3fc080
Compare
d3fc080 to
c369f5b
Compare
Replace Go standard `log` package with HashiCorp structured `tflog` for consistent logging across the provider. Changes: - Replace `log` import with `fmt` and add `tflog` import - Convert `log.Printf` to `tflog.Info` with structured fields Part of integrations#3070
Address review feedback: use static log message string instead of fmt.Sprintf inside tflog.Info. Remove now-unused "fmt" import.
07b7a72 to
64772a1
Compare
|
Friendly ping — is this still on the radar? Happy to rebase if needed. |
|
Hey @texasich 👋 This is on the radar, yes, but we're short on capacity right now and are focusing on some bigger QoL changes before merging anything else Sorry for the wait 😬 |
Replace Go standard
logpackage with HashiCorp structuredtflogfor consistent logging across the provider.Changes:
logimport withfmtand addtflogimportlog.Printftotflog.Infowith structured fieldsResolves [MAINT] Tracking issue for refactoring logging to use
tfloginstead oflog#3070 (partial — this PR covers one file)Before the change?
resource_github_actions_environment_variable.gouses Go's standardlog.Printffor logging, which produces unstructured output inconsistent with the rest of the provider.After the change?
Logging uses HashiCorp's
tflog.Infowith structured key-value fields (variable_id), consistent with the pattern established in other migrated files likeresource_github_membership.go.Pull request checklist