Skip to content

Comments

[BUG] Enable setting review notifications without delegation#3220

Open
deiga wants to merge 12 commits intointegrations:mainfrom
F-Secure-web:allow_setting_review_notifications_without_delegation
Open

[BUG] Enable setting review notifications without delegation#3220
deiga wants to merge 12 commits intointegrations:mainfrom
F-Secure-web:allow_setting_review_notifications_without_delegation

Conversation

@deiga
Copy link
Collaborator

@deiga deiga commented Feb 23, 2026 •
edited
Loading

Resolves #2273

Before the change?

  • Docs for github_team_settings we're missing computed attributes
  • Tests didn't cover all behaviour
  • Tests used legacy Check: structure
  • Resource didn't use Context-aware CRUD functions
  • Resource CRUD-functions we're tightly coupled
  • It was not possible to set an empty review_request_delegation block
  • It wasn't possible to set notify without enabling delegation

After the change?

  • Docs for github_team_settings are complete
  • Tests cover all behaviour
  • Tests use new check structures from terraform-plugin-testing
  • Resource uses Context-aware CRUD functions
  • Resource CRUD-functions are independent
  • It is possible to set an empty review_request_delegation block
  • It is possible to set notify without enabling delegation

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

deiga added 12 commits February 22, 2026 21:31
@deiga
Update docs
3c6bc31 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Fix linter issue
36fd84e 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Update tests and add missing coverage
7fa2bc8 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Add more tests to cover Import and a few more Update cases
20ad4bf 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Refactor Import to be Context-aware
1c7ba21 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Refactor to use Context-aware functions
ad3d308 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Use resource.ParallelTest to make testing quicker
981e2d3 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Remove unused call to Read
ad9307e 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Uncouple Create and Update
7fc881a 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Fix resource to be able to set empty review_request_delegation block
026c8b8 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Add top-level notify to enable setting it without `review_request_d…
78a77fa 
…elegation`

Mark nested `notify` as deprecated

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Update docs
62f6ed3 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@github-actions
Copy link

github-actions bot commented Feb 23, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@deiga deiga added this to the v6.12.0 Release milestone Feb 23, 2026
@deiga deiga added the Type: Bug Something isn't working as documented label Feb 23, 2026
@deiga deiga requested a review from stevehipwell February 23, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehipwell stevehipwell Awaiting requested review from stevehipwell

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Milestone

v6.12.0 Release

Development

Successfully merging this pull request may close these issues.

[BUG]: Allow setting review notifications without delegation

1 participant

@deiga