Skip to content

fix(data_source_github_release_asset): Fix #2514 remove accept header… #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felipebraga wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(data_source_github_release_asset): Fix #2514 remove accept header… #3186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion github/data_source_github_release_asset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ func dataSourceGithubReleaseAssetRead(ctx context.Context, d *schema.ResourceDat
return diag.FromErr(err)
}

req.Header.Set("Accept", "application/octet-stream")
resp, err := clientCopy.Do(req)
if err != nil {
return diag.FromErr(err)
Expand Down
8 changes: 4 additions & 4 deletions website/docs/d/release_asset.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ into a `file` attribute on the data source:

```hcl
data "github_release_asset" "example" {
repository = "example-repository"
owner = "example-owner"
asset_id = 12345
download_file = true
Copy link
Contributor

@mdb mdb Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch!

repository = "example-repository"
owner = "example-owner"
asset_id = 12345
download_file_contents = true
}
```

Expand Down