-
Notifications
You must be signed in to change notification settings - Fork 927
feat: Add github_organization_security_configuration and github_enterprise_security_configuration resource #3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit adds a new resource github_organization_security_configuration to manage Code Security Configurations at the organization level. It includes: - Resource implementation. - Acceptance tests. - Documentation. - Provider registration. Resolves integrations#2412
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
| Optional: true, | ||
| Default: "disabled", | ||
| Description: "The dependabot alerts configuration for the code security configuration. Can be one of 'enabled', 'disabled', 'not_set'.", | ||
| ValidateFunc: validation.StringInSlice([]string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use ValidateDiagFunc instead in all attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback @deiga. I have addressed the feedback in the latest commit to move to ValidateDiagFunc
Co-authored-by: Timo Sand <timo.sand@iki.fi>
|
Test re-run: |
|
Test: github_organization_security_configuration ==> Running acceptance tests on branch: 🌿 feat/organization-security-configuration 🌿...
TF_ACC=1 CGO_ENABLED=0 go test ./github/... -v -run '^TestAcc' -run='TestAccGithubOrganizationSecurityConfiguration' -timeout 120m -count=1
=== RUN TestAccGithubOrganizationSecurityConfiguration
=== RUN TestAccGithubOrganizationSecurityConfiguration/creates_organization_security_configuration_without_error
=== RUN TestAccGithubOrganizationSecurityConfiguration/updates_organization_security_configuration_without_error
=== RUN TestAccGithubOrganizationSecurityConfiguration/creates_organization_security_configuration_with_options
--- PASS: TestAccGithubOrganizationSecurityConfiguration (42.07s)
--- PASS: TestAccGithubOrganizationSecurityConfiguration/creates_organization_security_configuration_without_error (11.87s)
--- PASS: TestAccGithubOrganizationSecurityConfiguration/updates_organization_security_configuration_without_error (17.71s)
--- PASS: TestAccGithubOrganizationSecurityConfiguration/creates_organization_security_configuration_with_options (12.49s)
PASS
ok github.com/integrations/terraform-provider-github/v6/github 42.325sTest: github_enterprise_security_configuration ==> Running acceptance tests on branch: 🌿 feat/organization-security-configuration 🌿...
TF_ACC=1 CGO_ENABLED=0 go test ./github/... -v -run '^TestAcc' -run='TestAccGithubEnterpriseSecurityConfiguration' -timeout 120m -count=1
=== RUN TestAccGithubEnterpriseSecurityConfiguration
=== RUN TestAccGithubEnterpriseSecurityConfiguration/creates_enterprise_security_configuration_without_error
=== RUN TestAccGithubEnterpriseSecurityConfiguration/updates_enterprise_security_configuration_without_error
=== RUN TestAccGithubEnterpriseSecurityConfiguration/creates_enterprise_security_configuration_with_options
--- PASS: TestAccGithubEnterpriseSecurityConfiguration (41.65s)
--- PASS: TestAccGithubEnterpriseSecurityConfiguration/creates_enterprise_security_configuration_without_error (12.41s)
--- PASS: TestAccGithubEnterpriseSecurityConfiguration/updates_enterprise_security_configuration_without_error (17.24s)
--- PASS: TestAccGithubEnterpriseSecurityConfiguration/creates_enterprise_security_configuration_with_options (12.00s)
PASS
ok github.com/integrations/terraform-provider-github/v6/github 41.951s |
This commit adds a new resource github_organization_security_configuration & github_enterprise_security_configuration to manage Code Security Configurations at the organization & enterprise level respectively. It includes:
Resolves #2412
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Tests