Skip to content

Conversation

@acouvreur
Copy link
Contributor

When an environment no longer exist, the deletion call should not throw back an error.

The resource is in the desired state, gone.

Resolves #3131

Before the change?

  • Environments deleted externally would make the deletion fail

After the change?

  • Environments deleted externally will be deleted from the state

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

When an environment no longer exist, the deletion call should not throw back an error.

The resource is in the desired state, gone.
@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell stevehipwell added the Type: Bug Something isn't working as documented label Jan 28, 2026
@stevehipwell stevehipwell added this to the v6.11.0 Release milestone Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Swallow 404 Not Found when deleting environments

2 participants