fix: Correct forking and vulnerability alert logic #3127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2988
Resolves #3111
Before the change?
allow_forking = falseongithub_repositoryresulted in incorrect behaviourvulnerability_alertsattribute ofgithub_repositorycouldn't be left unset to support default behaviourgithub_repositoryallow forking and vulnerability alertsgithub_organization_role_usersdata source were brokenAfter the change?
allow_forking = falseongithub_repositoryworks as expectedvulnerability_alertsattribute ofgithub_repositoryworks correctly when unsetgithub_repositoryallow forking and vulnerability alerts addedgithub_organization_role_usersdata source fixedPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!