Skip to content

Conversation

@deiga
Copy link
Collaborator

@deiga deiga commented Jan 22, 2026


Before the change?

  • Code could be checking for if err != nil but return a different error

After the change?

  • Linter will mark that every checked error is being returned correctly

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@deiga deiga added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 22, 2026
@deiga deiga added this to the v6.11.0 Release milestone Jan 25, 2026
@deiga deiga requested a review from stevehipwell January 27, 2026 21:30
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, minor nits to fix.

FYI we still have a core linter disabled which need the code updating to re-enable it.

@deiga deiga requested a review from stevehipwell January 28, 2026 15:45
@deiga
Copy link
Collaborator Author

deiga commented Jan 28, 2026

I like this idea, minor nits to fix.

FYI we still have a core linter disabled which need the code updating to re-enable it.

Yeah, I tried enabling it and was overwhelmed 😂

stevehipwell
stevehipwell previously approved these changes Jan 28, 2026
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deiga and others added 3 commits January 30, 2026 00:00
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga deiga force-pushed the enable-nilnesserror-linter branch from a0503c4 to 1667d4e Compare January 29, 2026 22:00
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants