Skip to content

[MAINT] Remove unnecessary separate API call for repo topics in github_repository #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
deiga wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[MAINT] Remove unnecessary separate API call for repo topics in github_repository #3086

deiga wants to merge 6 commits into from

Conversation

@deiga
Copy link
Collaborator

@deiga deiga commented Jan 16, 2026 •
edited
Loading

Before the change?

  • Configuring topics for a github_repository would always do a separate API call to update topics, even though the Repo API nowadays supports topics directly

After the change?

  • No extra API calls when configuring topics for github_repository resources

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@stevehipwell stevehipwell added this to the v6.11.0 Release milestone Jan 16, 2026
@stevehipwell stevehipwell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 16, 2026
@deiga deiga marked this pull request as draft January 18, 2026 13:39
@stevehipwell
Copy link
Collaborator

stevehipwell commented Jan 19, 2026

@deiga have you seen the comment at the top of the edit repo REST API docs about updating topics?

@deiga
Copy link
Collaborator Author

deiga commented Jan 19, 2026

@deiga have you seen the comment at the top of the edit repo REST API docs about updating topics?

Yeah, I spotted it yesterday and re-drafted this. There is still useful cleanup here

@deiga deiga force-pushed the remove-unnecessary-topics-api-call branch from ac97cf8 to c8e8f67 Compare January 22, 2026 20:34
@deiga deiga marked this pull request as ready for review January 22, 2026 20:35
stevehipwell
stevehipwell requested changes Jan 27, 2026
View reviewed changes
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in principal, just a few suggesitons/questions.

@deiga deiga requested a review from stevehipwell January 27, 2026 21:07
@deiga
Copy link
Collaborator Author

deiga commented Jan 27, 2026

@stevehipwell Thanks for the review, I've addressed your comments

stevehipwell
stevehipwell approved these changes Jan 28, 2026
View reviewed changes
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deiga added 6 commits January 29, 2026 22:36
@deiga
Remove duplicate code
aaa1d32 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Inline repoReq.Topics
5f59ba7 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Remove clearly unnecessary SetId
d137ff0 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Use repo.GetName() instead of *repo.Name
effd268 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Address review comments
bb9cff0 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
Some test structure reformatting
61d0170 
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga deiga force-pushed the remove-unnecessary-topics-api-call branch from 3ee38f1 to 61d0170 Compare January 29, 2026 20:36
@deiga deiga requested a review from nickfloyd January 30, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehipwell stevehipwell stevehipwell approved these changes

@nickfloyd nickfloyd Awaiting requested review from nickfloyd

Assignees

No one assigned

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Milestone

v6.11.0 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@deiga @stevehipwell