Skip to content

[Doc] Fix documentation mistake for github_repository_dependabot_security_update resource to use GitHub repository name #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2024
Merged

[Doc] Fix documentation mistake for github_repository_dependabot_security_update resource to use GitHub repository name #2439

merged 3 commits into from
Nov 26, 2024

Conversation

ViacheslavKudinov
Copy link
Contributor

@ViacheslavKudinov ViacheslavKudinov commented Oct 27, 2024 •
edited
Loading

Resolves #2433

Before the change?

  • Documentation had mistake that it has to be use repository id

After the change?

  • Documentation has been updated with example where is used repository name. Aslo has been update argument with explicitly said to use name of repository.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • [ x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

No, just a documentation correction.

Please see our docs on breaking changes to help!

  • Yes
  • [x ] No

@ViacheslavKudinov
Fix documentation mistake for github_repository_dependabot_security_u…
458d282 
…pdate resource to use GitHub repository name
@ViacheslavKudinov ViacheslavKudinov changed the title Fix documentation mistake for github_repository_dependabot_security_update resource to use GitHub repository name [Doc] Fix documentation mistake for github_repository_dependabot_security_update resource to use GitHub repository name Oct 27, 2024
@ViacheslavKudinov ViacheslavKudinov marked this pull request as ready for review October 27, 2024 09:24
@ViacheslavKudinov ViacheslavKudinov mentioned this pull request Oct 27, 2024
Closed
1 task
kfcampbell
kfcampbell approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@kfcampbell kfcampbell merged commit 1c11053 into integrations:main Nov 26, 2024
3 checks passed
@ViacheslavKudinov
Copy link
Contributor Author

Thank you for doing this!

You are welcome, and it is a small contribution.
I'm far behind than many great contributions other more experienced people do.

Thanks to all the community for an amazing job they all do!

MXfive pushed a commit to MXfive/terraform-provider-github that referenced this pull request Nov 27, 2024
@ViacheslavKudinov @kfcampbell @MXfive
Fix documentation mistake for github_repository_dependabot_security_u…
aaa5906 
…pdate resource to use GitHub repository name (integrations#2439)

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
@ViacheslavKudinov ViacheslavKudinov deleted the documentation/github_repository_dependabot_security_updates branch November 27, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kfcampbell kfcampbell kfcampbell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DOCS]: github_repository_dependabot_security_updates resource in doc uses github_repository.test.id instead of github_repository.test.name

2 participants

@ViacheslavKudinov @kfcampbell