Skip to content

[DOCS]: Behaviour change in 6.12.1 vs 6.11.1 #3434

@quotidian-ennui

Description

@quotidian-ennui

Describe the need

THere's a side effect related to #3233 or maybe its related ones such that if you have github_repository_collaborators configured, for a personal, public repository

resource "github_repository_collaborators" "public_repo" {
  repository = "gh-my"
  user {
    username = "stevehipwell"
    permission = "write"
  }
}

Then you will always get tofu plan churn once it is applied, since you will repeatedly get this emitted when you plan.

  ~ resource "github_repository_collaborators" "public_repo" {
        id             = "xxxxxx"
      ~ invitation_ids = {} -> (known after apply)
        # (2 unchanged attributes hidden)

      - user {
          - permission = "admin" -> null
          - username   = "quotidian-ennui" -> null
        }

        # (1 unchanged block hidden)
    }

The work-around is to do add the repository owner as an admin.

resource "github_repository_collaborators" "public_repo" {
  repository = "gh-my"
  user {
    username = "stevehipwell"
    permission = "write"
  }
  user {
    username = "quotidian-ennui"
    permission = "admin"
  }
}

The behavioural change isn't a problem, but it needs to be made clearer.

  • I wouldn't consider myself a collaborator on my own repository
  • The documentation itself states for personal repositories, you only have the write permission to grant.
    c.f.

For personal repositories, collaborators can only be granted write (implicitly includes read) permission.

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: TriageThis is being looked at and prioritizedType: DocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions