Skip to content

Include slf4j-simple in tests #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Include slf4j-simple in tests #38

merged 1 commit into from
Oct 17, 2023

Conversation

fourls
Copy link
Collaborator

@fourls fourls commented Oct 6, 2023

In commit ca64fa4, SonarDelphi's internal logging was migrated to SLF4J, which SonarQube automatically provides in the plugin context. When running tests, however, there is no SLF4J implementation provided, which produces an error message and falls back to a no-op logger.

This PR includes slf4j-simple as a test dependency, which provides a simple logging implementation that writes all logs to standard error.

Copy link
Collaborator

@cirras cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@cirras cirras merged commit e166e3c into master Oct 17, 2023
@cirras cirras deleted the slf4j-tests branch October 17, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants