INTLY-7486: Point amq console links to the parent link instead of the address space link#583
Merged
INTLY-7486: Point amq console links to the parent link instead of the address space link#583
Conversation
Contributor
Author
|
ping @tiffanynolan |
pb82
approved these changes
May 8, 2020
Contributor
pb82
left a comment
There was a problem hiding this comment.
@tiffanynolan we have verified this change on OS3 and OS4. If @mfrances17 and @dlabaj are ok with it I think we can get it merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.redhat.com/browse/INTLY-7486
This change ensures amq online url points to the parent console instead of address space on os3.
Reason for change
The AMQ console route has changed from
console-proxytoconsolein the new AMQ version 1.4. It's path to the address space also has a new format.After upgrade from rhmi 1.6 to 1.7, the dashboardUrl in the address space of the service instance still remained pointing to the
console-proxyroute which is being used by the webapp to populate the amq console links in the managed services menu and within the walkthroughs.This dashboardurl field is managed by the AMQ service broker itself and cannot be modified once created.
Instead of pointing to the address space itself, we should point to the 'parent' amq console link. This will enable us to no longer rely on the dashboardUrl field in the service instance. It will also allow us to ensure that the url to the amq console will always be correct on future versions if it changes again. The AMQ url will now be made available to the webapp through the
INSTALLED_SERVICESfield.Related Walkthrough changes: integr8ly/tutorial-web-app-walkthroughs#137
Verification steps
Installation
Verified on OSD OS3:
Before amq was provisioned:

After amq was provisioned, each amq console link redirected you to the following url: https://console-openshift-enmasse.f2d1.rhmi-qe1.openshiftapps.com/#/address-spaces
This was also verified on OS4 by @pb82.
Changes did not affect routes in OS4. This change only affected the AMQ route on OS3.
WT1A was tested with the following PR: integr8ly/tutorial-web-app-walkthroughs#137
Upgrade
Steps to verify changes on upgrade from RHMI 1.6 to 1.7:
spec.parametersquay.io/jameelb/tutorial-web-app:masterVerified changes on upgrade from RHMI 1.6 to 1.7. WT1A still works, previously sent messages can still be seen in the order app. New messages can still be sent.